-
Notifications
You must be signed in to change notification settings - Fork 7.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Update Values before after_mapping
hook is called
#42682
Conversation
This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing. |
Head branch was pushed to by a user without write access
cf558ce
to
efdeeaf
Compare
This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing. |
* fix: update values before after_mapping hook is called * fix: appropriate function name (cherry picked from commit 26fc8ce) # Conflicts: # erpnext/buying/doctype/purchase_order/purchase_order.py
* fix: update values before after_mapping hook is called * fix: appropriate function name
* fix: update values before after_mapping hook is called * fix: appropriate function name
fix: Update Values before `after_mapping` hook is called (backport #42682)
## [15.38.1](v15.38.0...v15.38.1) (2024-10-09) ### Bug Fixes * 'NoneType' object has no attribute 'has_serial_no' (backport [#43514](#43514)) ([#43574](#43574)) ([60508a9](60508a9)) * [#42014](#42014) --resolve conflicts ([85d7405](85d7405)) * Accepted and Rejected warehouse cannot be same (backport [#43568](#43568)) ([#43573](#43573)) ([83ce3dd](83ce3dd)) * add include closed orders option in so/po trends report v15 ([5660e8b](5660e8b)) * add parenttype condition for item table in Purchase Register Report ([8ce81a0](8ce81a0)) * Add removed test code `https://github.com/frappe/erpnext/commit/b41f10c1b98b01a181a6f9dbdf2531b108dc3bae` ([30fd11f](30fd11f)) * allow to change the batch in the subcontracting receipt (backport [#43584](#43584)) ([#43588](#43588)) ([9e109ac](9e109ac)) * create Account Closing Balance even though there are no transaction in period ([d6f70f5](d6f70f5)) * creation of contact, customer, opportunity, quotation and prospect from lead ([ef10c4e](ef10c4e)) * creation of contact, customer, opportunity, quotation and prospect from lead --prettier ([5a2a404](5a2a404)) * deduct advances adjusted for threshold check for tcs ([6decb7c](6decb7c)) * do not include advances for tds vouchers ([ee8485a](ee8485a)) * frappe dependency update ([0a70b3f](0a70b3f)) * include parent item group in query ([55464c7](55464c7)) * make LCV button not working for PI and PR (backport [#43592](#43592)) ([#43593](#43593)) ([120b481](120b481)) * multiple issues in Payment Request ([#42427](#42427)) ([ea69ba7](ea69ba7)) * production plan bom error (backport [#43591](#43591)) ([#43594](#43594)) ([029021f](029021f)) * read only filters in multidialog fields (backport [#43503](#43503)) ([#43513](#43513)) ([d69a974](d69a974)) * Remove `advance_payment_status` uses ([907e3af](907e3af)) * Remove unreference method ([770bc1c](770bc1c)) * Remove unused field ([e785928](e785928)) * Remove unused function `get_paid_amount_against_order` ([7591662](7591662)) * Separate `on_submit` and `before_submit` of PR ([dbd7b83](dbd7b83)) * the purchase receipt trends and delivery note trends report (backport [#43585](#43585)) ([#43587](#43587)) ([355ba2f](355ba2f)) * Unknown column 'serial_no' in 'field list' (backport [#43515](#43515)) ([#43569](#43569)) ([fc9a3c0](fc9a3c0)) * Update Values before `after_mapping` hook is called ([#42682](#42682)) ([6770610](6770610)) * validation for corrective job card (backport [#43555](#43555)) ([#43558](#43558)) ([cf0fa0d](cf0fa0d))
Issue:
Reference: Override mapped doc in ERPNext for creating Subcontracting Order. resilient-tech/india-compliance#2481
When creating
Subcontracting Order
fromPurchase Order
, the taxes of Purchase Doctype and Sales Doctype are not same which raises error so mapping has to be done according toSales Taxes and Charges
.